-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Filter Device To Force High Frame Rate #880
Conversation
I'm not sure why but I also use a realme narzo 50. Which has 120hz refresh-rate and it's buttery smooth |
Maybe instead of filtering devices, we let the user choose if they want this or not? |
We can enable high refresh rate by default but we'll check if the current refresh rate is >=60 or not. If it's below 60 we'll ask the user to disable it with a dialog in the settings with toggle |
That's a good idea, although it's not every brand device that uses the buggy OS has this bug |
Or maybe, you could detect the after-changes fps with the target set fps, |
Yeah, that is what I was proposing at first. But we'll let the user know and let them decide if they want to change or not. |
Would the user get too many prompts at the first run (with the battery optimization warning)? I think it would be the best experience to do the failsafe method like you suggesting without giving them warning since many other apps out there don't do this warning just for the FPS thing |
Hmm, that's also true. Yeah lets go that direction |
Hey, just wanna catch up, is there any improvement that I can make for this PR? |
In a device like mine (Xiaomi), applying force HFR is resulting in a drop fps.
Filtering the device brand using
AndroidDeviceInfo.brand
helps to fix this bug.Note: My current Display Frame Rate is set to 90Hz