Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Duration Match Algorithm (Needs Testing) #191

Merged
merged 5 commits into from
Sep 19, 2022

Conversation

Demizo
Copy link
Contributor

@Demizo Demizo commented Sep 2, 2022

  • Added duration matching option to track matching algorithms.

Matching based on song duration greatly improves Spotube's accuracy in playing the correct song. It also solves the issue of artists having more than one version of a song with the same name. Duration matching helps to root out music videos as well. While I personally believe that duration matching should be built into all the matching algorithms, I decided it might be best to just make it an option for now and see how it is received.

@KRTirtho
Copy link
Owner

KRTirtho commented Sep 3, 2022

duration matching should be built into all the matching algorithms

Right, I think having it as a part of authentic popular would be a better choice. From my testing, I've found just matching the duration isn't good enough, as sometimes covers & remixes (even lofis) get ranked higher in result (maybe because official music videos contain off music stuff too sometimes). Though popular tracks work fine mostly but when we hit the local music, it fails almost all the time 😕

@Demizo
Copy link
Contributor Author

Demizo commented Sep 3, 2022

I can look into this tomorrow. I agree with you, it is better suited as an "authenticity" tool than an algorithm on its own

@KRTirtho
Copy link
Owner

KRTirtho commented Sep 3, 2022

Let's keep it for the later release. The upcoming v2.4.0 already has a bunch of features and improvements 😅. Also duration matcher needs some testing too which can take some time

- Integrated duration matching into authentic and popular algorithms
- Removed duration matching option
@Demizo Demizo changed the title [Feature] Add Duration Match Algorithm [Feature] Add Duration Match Algorithm (Needs Testing) Sep 3, 2022
@Demizo
Copy link
Contributor Author

Demizo commented Sep 3, 2022

Duration matching is now integrated into both the popular and authentic matching algorithms. Songs within 10 seconds of the actual song duration are granted +1 rating. This should prevent duration matching from overpowering other methods of authentication while boosting the most authentic tracks. 10 seconds is a magic number and could be fine tuned with testing (especially needs testing with more niche music)

@KRTirtho
Copy link
Owner

Hey, @Demizo can you sync with the latest changes?

@Demizo
Copy link
Contributor Author

Demizo commented Sep 18, 2022

Sure!

@KRTirtho KRTirtho merged commit 9ba46e3 into KRTirtho:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants