-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Duration Match Algorithm (Needs Testing) #191
Conversation
Added duration matching option to track matching algorithms
Right, I think having it as a part of |
I can look into this tomorrow. I agree with you, it is better suited as an "authenticity" tool than an algorithm on its own |
Let's keep it for the later release. The upcoming v2.4.0 already has a bunch of features and improvements 😅. Also duration matcher needs some testing too which can take some time |
- Integrated duration matching into authentic and popular algorithms - Removed duration matching option
Duration matching is now integrated into both the popular and authentic matching algorithms. Songs within 10 seconds of the actual song duration are granted +1 rating. This should prevent duration matching from overpowering other methods of authentication while boosting the most authentic tracks. 10 seconds is a magic number and could be fine tuned with testing (especially needs testing with more niche music) |
Hey, @Demizo can you sync with the latest changes? |
Sure! |
Matching based on song duration greatly improves Spotube's accuracy in playing the correct song. It also solves the issue of artists having more than one version of a song with the same name. Duration matching helps to root out music videos as well. While I personally believe that duration matching should be built into all the matching algorithms, I decided it might be best to just make it an option for now and see how it is received.