Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linux): Use XDG_STATE_HOME to storage logs #1675

Merged
merged 3 commits into from
Jul 14, 2024
Merged

feat(linux): Use XDG_STATE_HOME to storage logs #1675

merged 3 commits into from
Jul 14, 2024

Conversation

arenekosreal
Copy link
Contributor

We storage logs at ~/Documents/.spotube_logs on Linux currently, this does not follow XDG specification. XDG specification is used by many modern GUI apps to storage data on Linux.

Copy link
Owner

@KRTirtho KRTirtho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logger is kind of deprecated, the new logger that is used accorss the codebase is in lib/services/logger/logger.dart

lib/models/logger.dart Outdated Show resolved Hide resolved
@KRTirtho KRTirtho changed the base branch from master to dev July 6, 2024 16:02
@arenekosreal
Copy link
Contributor Author

This logger is kind of deprecated, the new logger that is used accorss the codebase is in lib/services/logger/logger.dart

Ah, I found that there are some differences between dev and master branches. I will do some work to port this patch to make it compatible to dev branch.

@arenekosreal

This comment was marked as outdated.

@arenekosreal arenekosreal requested a review from KRTirtho July 7, 2024 07:32
@KRTirtho
Copy link
Owner

KRTirtho commented Jul 7, 2024

Try with flutter 3.19.x

We've not yet updated to flutter 3.22.x

@arenekosreal
Copy link
Contributor Author

Nevermind, I cleaned .dart_tool folder and rebuilt everything, finally this problem was gone.

Copy link
Owner

@KRTirtho KRTirtho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KRTirtho KRTirtho merged commit e6fee03 into KRTirtho:dev Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants