Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Song timer cannot go down when skipping around in a song, only can go up or to 0:00. #695

Closed
1 task done
octia opened this issue Sep 2, 2023 · 2 comments
Closed
1 task done
Labels
bug Something isn't working UI A suggestion/bug report of a UI element

Comments

@octia
Copy link

octia commented Sep 2, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When playing a song, and skipping backwards, the current time doesn't change - unless the skip was to 0:00.
After skipping to a previous point in the track, the displayed time remains the same - until the pre-skip point was reached again, then it resumes normally. It also resumes counting properly when skipping ahead of the point that it's displaying at the moment.

Expected Behavior

If I skip backwards in a song, I'd like to know what exact time in the song it is.

Steps to reproduce

  1. Play anything.
  2. Wait so that the song timer is above 0:02 - doesn't really matter much how much. (above 0:02, because if it was 0:01, the only possible skip would be to 0:00. And 0:00 is a magic value where correct behaviour happens).
  3. Move the slider that displays the current time in the song, backwards - effectively skipping backwards in the song. (Again, do not skip to 0:00)
  4. Notice that the song timer has not skipped along with the track - it still displays the same value. For example if at 1:00 you skipped to 0:30, the timer would display 1:00 for 30 seconds, then resume going forward, together with the song).
  5. Now optionally skip to 0:00. Notice how the timer gets properly set to 0:00, and increments every second, along with the song, properly.

Operating System

Tested on Linux. Not tested on anything else.

Spotube version

3.1.1

Installation source

Arch User Repository (AUR)

Additional information

image

This is clearly not 03:19 in a song that lasts 03:31.

It should be noted that the song is skipping backwards properly. Simply the timer is displaying the wrong thing.

@octia octia added the bug Something isn't working label Sep 2, 2023
@KRTirtho
Copy link
Owner

KRTirtho commented Sep 3, 2023

OMG how the hack that gone unnoticed all this time 😅
Thanks for opening the issue 👍

@KRTirtho KRTirtho moved this to Backlog in Spotube Board Sep 3, 2023
@KRTirtho KRTirtho added the UI A suggestion/bug report of a UI element label Sep 7, 2023
@KRTirtho
Copy link
Owner

It's been fixed

@KRTirtho KRTirtho moved this from Backlog to Deployed in Spotube Board Sep 16, 2023
@github-project-automation github-project-automation bot moved this from Deployed to Done in Spotube Board Sep 16, 2023
meenbeese pushed a commit to meenbeese/spotube that referenced this issue Sep 20, 2023
meenbeese pushed a commit to meenbeese/spotube that referenced this issue Sep 20, 2023
meenbeese pushed a commit to meenbeese/spotube that referenced this issue Sep 20, 2023
@KRTirtho KRTirtho moved this from Done to Deployed in Spotube Board Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI A suggestion/bug report of a UI element
Projects
Status: Deployed
Development

No branches or pull requests

2 participants