Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flatpak] Follow system theme #50

Closed
aha999 opened this issue Apr 4, 2022 · 2 comments
Closed

[Flatpak] Follow system theme #50

aha999 opened this issue Apr 4, 2022 · 2 comments
Labels
deployed This issue has been fixed/implmented and has been released enhancement New feature or request UI A suggestion/bug report of a UI element
Milestone

Comments

@aha999
Copy link

aha999 commented Apr 4, 2022

Is your feature request related to a problem? Please describe.
Currently when you enter the app for the first time, it has a white theme, which is inconsistent with the system if you're using a dark theme system-wide and the apps adopt this.

Describe the solution you'd like
The app should follow the system theme by default. If the OS or desktop environment theme is dark, the app should have a dark theme, and vice versa. Manual theming options should of course still be accessible, but the default option should be "Follow system theme."

My specs
OS: EndeavourOS
App version Spotube v2.0.0
DE: KDE Plasma 5.24.4
App package installed: Flatpak

@aha999 aha999 added the enhancement New feature or request label Apr 4, 2022
@KRTirtho
Copy link
Owner

KRTirtho commented Apr 5, 2022

The Flatpak version doesn't follow the system themes as the Flatpak sandbox doesn't provide the system color scheme yet. Although freedesktop has announced system theme access to snadbox for consistency recently but it might take little of time to get onboard

@KRTirtho KRTirtho changed the title Follow system theme [Flatpak] Follow system theme Jun 5, 2022
@RaptaG RaptaG added the UI A suggestion/bug report of a UI element label Mar 8, 2023
@KRTirtho
Copy link
Owner

Starting from v3 Spotube can now detect dark mode inside Flatpak as well

@KRTirtho KRTirtho added the deployed This issue has been fixed/implmented and has been released label Aug 26, 2023
@KRTirtho KRTirtho moved this to Deployed in Spotube Board Aug 26, 2023
@KRTirtho KRTirtho added this to the Version 3.0.0 milestone Aug 26, 2023
@github-project-automation github-project-automation bot moved this from Deployed to Done in Spotube Board Aug 28, 2023
@KRTirtho KRTirtho moved this from Done to Deployed in Spotube Board Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed This issue has been fixed/implmented and has been released enhancement New feature or request UI A suggestion/bug report of a UI element
Projects
Status: Deployed
Development

No branches or pull requests

3 participants