Fixes #50
Merged
Fixes #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as abuse.
This comment was marked as abuse.
KRTirtho
approved these changes
Mar 4, 2024
|
any idea when these fixes will be released? i need the fix for issue #34 |
mauriciolcs2
reviewed
May 8, 2024
| @@ -184,6 +184,8 @@ class Query<DataType, ErrorType> | |||
| if (error is ErrorType) _errorController.add(error); | |||
There was a problem hiding this comment.
maybe we'll have to throw the error here? otherwise this future will always be completed and we won't be able to handle the error.
try {
await mutation.mutate()
} catch (e) {
// will never reach here
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49, #37 and #34