Repository navigation
test(cmd/vedette): wait for run to stop before removing the temp dir (CI flake on #82) - #83
Merged
Merged
Conversation
start and startArgs cancelled run at cleanup but never waited for it, so t.TempDir's RemoveAll raced the shutdown's last writes (CI on #82: "TempDir RemoveAll cleanup: unlinkat …/001: directory not empty" in TestLoopbackHTTPHostAllowlist). waitStopped cancels and waits (30 s bound) in a cleanup registered after the temp dir, so it runs first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
startandstartArgsincmd/vedettetests cancelledrunat cleanup but never waited for it to return.t.TempDir'sRemoveAllthen raced the shutdown's last writes. CI on #82 (docs only) failed with:waitStoppedcancelsrunand then waits for it to return, bounded at 30 s. Its cleanup is registered aftert.TempDir, and cleanups run last-in first-out, so it runs before the temp dir is removed.Local checks
🤖 Generated with Claude Code