Replace deprecated platform.distro call with distro module#13
Closed
odel4y wants to merge 2 commits intoKIT-MRT:masterfrom
odel4y:platform-distro-fix
Closed
Replace deprecated platform.distro call with distro module#13odel4y wants to merge 2 commits intoKIT-MRT:masterfrom odel4y:platform-distro-fix
odel4y wants to merge 2 commits intoKIT-MRT:masterfrom
odel4y:platform-distro-fix
Conversation
Author
|
I also raised the CMake version to suppress warnings with Noetic. However I am not sure whether this breaks compatibility with earlier ROS releases. |
Contributor
|
Thanks for fixing! Your PR revealed a problem with Raising the CMake version requirement should be fine. This package not been released below melodic, where 3.7 can be assumed. |
Contributor
|
Closing this, because its already fixed by df568cb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for #12. Also added python-distro or python3-distro as build dependency.