Skip to content

Conversation

@ntn-x2
Copy link
Contributor

@ntn-x2 ntn-x2 commented Mar 22, 2022

The DID logic did not include any DID key for the didLookup pallet, which accepts a DID origin with an authentication key.

How to test

Use "@kiltprotocol/sdk-js": "0.26.1-beta.1" against a version of the node that has the fixed origin, e.g., KILTprotocol/kilt-node#343.

@ntn-x2 ntn-x2 added 🐛 bug priority: bug ❤️ high priority: high labels Mar 22, 2022
@ntn-x2 ntn-x2 requested review from rflechtner and tjwelde March 22, 2022 08:15
@ntn-x2 ntn-x2 self-assigned this Mar 22, 2022
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@ntn-x2 ntn-x2 merged commit 5ed62d6 into master Mar 22, 2022
@ntn-x2 ntn-x2 deleted the aa-did-lookup-fix branch March 22, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug priority: bug ❤️ high priority: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants