Skip to content

Conversation

@rflechtner
Copy link
Contributor

fixes #504

As far as I can see the only issue leading to failure in our weekly run with updated deps is that the integration tests are out of sync with the latest chain runtime. This should take care of the problem.

@rflechtner rflechtner requested a review from ntn-x2 March 21, 2022 18:40
@rflechtner rflechtner changed the base branch from develop to master March 21, 2022 18:40
Copy link
Contributor

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Unfortunately, the merging of KILTprotocol/kilt-node#316 into develop means that integration tests now are again broken, because something changed in the storage layout. It is definitely not to be fixed in this PR, but I guess we will keep having problems as long as the issue is not fixed, or as long as we can't safely ignore the result of testing against latest-develop.

@rflechtner
Copy link
Contributor Author

LGTM! Unfortunately, the merging of KILTprotocol/mashnet-node#316 into develop means that integration tests now are again broken, because something changed in the storage layout. It is definitely not to be fixed in this PR, but I guess we will keep having problems as long as the issue is not fixed, or as long as we can't safely ignore the result of testing against latest-develop.

Technically the tests against latest-develop are optional, so this may hit us only later when these changes are released - although the GitHub Actions status has behaved somewhat inconsistently in the past

@rflechtner rflechtner merged commit b5a13bf into master Mar 22, 2022
@rflechtner rflechtner deleted the hotfix-integrationtests branch March 22, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK no longer compatible with latest dependecies

3 participants