Conversation
weichweich
approved these changes
Mar 1, 2023
Contributor
weichweich
left a comment
weichweich
left a comment
There was a problem hiding this comment.
LGTM
I guess we are introducing the "Prove Size Weights" in a different PR?
Contributor
Author
|
@weichweich I created a ticket https://github.com/KILTprotocol/ticket/issues/2486. I think we can go ahead an merge this, since the main reason why I did it was the new XCM support. |
Contributor
|
I checked the code and went through all the PRs since 0.9.37 and can't spot anything that's missing :) LGTM 🥳 |
trusch
approved these changes
Mar 1, 2023
Ad96el
pushed a commit
that referenced
this pull request
Mar 20, 2023
fixes https://github.com/KILTprotocol/ticket/issues/2464 Fixes #481 -> see issue description for a complete list of PRs. - paritytech/polkadot#4097 (XCM v3) - paritytech/polkadot#6490 (root origin can issue grants on behalf of the treasury) - paritytech/substrate#13214 (we used in the the staking pallet but we never called the `set` function, so we don't need to do anything) - paritytech/substrate#13216 (removes all calls and intrinsics from the authorship pallet) Release analysis: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-38/2122 If any of the runtimes is complied with just the `runtime-benchmarks` features, there is a compilation issue due to some nested dependencies. Linked issue: paritytech/cumulus#2230. --------- Co-authored-by: Tino Rusch <tino@kilt.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/2464
Fixes #481 -> see issue description for a complete list of PRs.
Relevant changes
setfunction, so we don't need to do anything)unclesrelated code paritytech/substrate#13216 (removes all calls and intrinsics from the authorship pallet)Release analysis: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-38/2122
Open issues
If any of the runtimes is complied with just the
runtime-benchmarksfeatures, there is a compilation issue due to some nested dependencies. Linked issue: paritytech/cumulus#2230.