Skip to content

Conversation

@wischli
Copy link
Contributor

@wischli wischli commented Sep 2, 2022

fixes KILTProtocol/ticket#2168

Note worthy Substrate PRs

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@wischli wischli requested a review from weichweich September 7, 2022 09:59
Copy link
Contributor

@weichweich weichweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

regarding the delegations. I think the behavior is not that great now. I'll create an entry in our tracking tool for it

@wischli wischli merged commit ec36097 into develop Sep 7, 2022
@wischli wischli deleted the wf-2168-polkadot-v0.9.28 branch September 7, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants