Skip to content

use ci-linux:production base image #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wischli merged 3 commits into from
Jun 13, 2022
Merged

use ci-linux:production base image #368

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ab381f
use ci-linx:production base image
ggera Jun 9, 2022
43778ae
Use hash tag on ci-linux to have more control than latest production
ggera Jun 10, 2022
c4f550d
Merge branch 'develop' into ci-linux
wischli Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# this container builds the kilt-parachain binary from source files and the runtime library
# pinned the version to avoid build cache invalidation

# c4f0daf3-20220110 -> rust version rustc 1.58.0-nightly (46b8e7488 2021-11-07)
FROM paritytech/ci-linux:f203f298-20220421 as builder
FROM docker.io/paritytech/ci-linux:production as builder

@wischli wischli Jun 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear that the production image will be bumped up by Parity while we want to have full control over bumping the image to reduce error likelihood when building.

I suggest to stay with a distinct hash. The one suggested has the same digest as the current production one, e.g., they are the same.

Suggested change
FROM docker.io/paritytech/ci-linux:production as builder
FROM paritytech/ci-linux:eb1f6a26-20220518

@ggera ggera Jun 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I was kinda puzzled. Since the toolchain file has precedence over the docker image, we kinda have no control.


WORKDIR /build

Expand Down