Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore empty command line arguments #659

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GitMensch
Copy link
Contributor

Those can be passed by tools calling HotSpot and lead to "File '' does not exist." error messages.

One example "tool" is vscode - you can either start external programs with no arguments or with user-inputs (for example a , but if you have an empty user input (aka "just start hotspot") you get that error message.

@GitMensch GitMensch force-pushed the patch-1 branch 2 times, most recently from 22a64b9 to 7fd1ce6 Compare June 7, 2024 18:50
@GitMensch
Copy link
Contributor Author

GitMensch commented Jun 7, 2024

Hm, thinking about that; maybe it would be nice to allow opening hotspot without "perf.data", even if it exists - this could also be triggered by the empty file "" (or a new binary option).

Thoughts?

@milianw
Copy link
Member

milianw commented Jun 15, 2024

Hm, thinking about that; maybe it would be nice to allow opening hotspot without "perf.data", even if it exists - this could also be triggered by the empty file "" (or a new binary option).

Thoughts?

Up to you, if you see a need for it I'm not going to oppose a patch for that.

src/main.cpp Outdated Show resolved Hide resolved
Those can be passed by tools calling HotSpot and lead to "File '' does not exist." error messages.
@GitMensch
Copy link
Contributor Author

Hm, thinking about that; maybe it would be nice to allow opening hotspot without "perf.data", even if it exists - this could also be triggered by the empty file "" (or a new binary option).
Thoughts?

Up to you, if you see a need for it I'm not going to oppose a patch for that.

I think if we extend #660 to start on several pages (for starters at least "recording" and "open") this issue is solved. Please have a look there any comment about a possible --startPage or how you'd name an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants