Skip to content

fix: Qrc test data#989

Closed
LeonMatthesKDAB wants to merge 1 commit intoKDAB:mainfrom
LeonMatthesKDAB:fix-qrc-tests
Closed

fix: Qrc test data#989
LeonMatthesKDAB wants to merge 1 commit intoKDAB:mainfrom
LeonMatthesKDAB:fix-qrc-tests

Conversation

@LeonMatthesKDAB
Copy link

This was accidentally only running the data from the "invalid" test case, as JS was merging everything into a single object, instead of two objects in an array.

This was accidentally only running the data from the "invalid" test
case, as JS was merging everything into a single object, instead of two
objects in an array.
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@LeonMatthesKDAB LeonMatthesKDAB enabled auto-merge (rebase) July 8, 2024 09:36
@ahayzen-kdab
Copy link
Collaborator

So this will be superseded by #986 ?

@LeonMatthesKDAB
Copy link
Author

Yes, it's part of #986 now.
Apparently this didn't even work before 😅

auto-merge was automatically disabled July 8, 2024 14:22

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants