examples: add a unit test to ensure that qrc works#981
examples: add a unit test to ensure that qrc works#981LeonMatthesKDAB merged 1 commit intoKDAB:mainfrom
Conversation
|
Hm, I wonder whether we even want to support QRC files this way in a CMake-driven build. There is really little reason to do this over simply adding the qrc file to the CMake build 🤔 This should definitely work if you're running a Cargo-only build, but maybe we shouldn't support this in CMake-based builds? |
|
I think it'd be tricky to explicitly disable for CMake builds and in theory shouldn't really be any different between CMake or Cargo builds as seen in the diff here. For the object files the initialiser can just go into the crate's general initialiser so that we don't need to know the qrc name at the figure stage? |
|
That would work, as long as the qrc call happens in the build script of the final crate. |
|
Hmm fun, but that is also true for cargo builds too? Any qrc's added in cxx-qt-lib would need an initialiser to be passed through via opts to the final build script? |
|
Cargo builds should work, even with dependencies as I'm adding the object file generated by each qrc file to the linker if it's a cargo-only build. But I also haven't tested that yet. |
68b5fcb to
acda73a
Compare
LeonMatthesKDAB
left a comment
There was a problem hiding this comment.
more test, more better, and this should be doable to support in our upcoming changes in #986
No description provided.