Repository navigation
perf(web): prune duplicate shell chrome update during page rendering - #36
Merged
Merged
Conversation
Inspired by pingdotgg/t3code#20860, pingdotgg/t3code#18416. renderPage previously invoked updateShellChrome twice: once before loading the async page module chunk and once immediately after. The second call was completely redundant since store stats and route path are unchanged.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
renderPage(path)insrc/main.jswas invokingupdateShellChrome(normalizedPath)twice during each route navigation:ensureShell(); bindShellEvents(); updateShellChrome(normalizedPath);)updateShellChrome(normalizedPath);)Because store stats, user details, and the active route path do not change while the page module chunk is resolving, the second invocation was entirely redundant. It performed repeated calculations of
store.getProgress()andstore.getTotalHours(), alongside duplicate DOM writes to sidebar navigation classes, theme toggle labels, and progress bars.Mechanism
Remove the redundant
updateShellChrome(normalizedPath)call insrc/main.js.The initial call is preserved so that sidebar navigation links update immediately upon user interaction before module resolution.
Upstream Inspiration
Before / After Numbers
npm test: 124/124 tests passing.npm run build: Vite build passes cleanly.Risk
Very Low. The shell chrome has already been rendered and updated by the initial call before module resolution.