Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the sample app #70

Merged
merged 7 commits into from
Mar 30, 2020
Merged

Updating the sample app #70

merged 7 commits into from
Mar 30, 2020

Conversation

philips77
Copy link
Collaborator

This PR includes:

  • updating all dependencies, fixing all related issues, including Dagger,
  • requesting ACCESS_FINE_LOCATION permission, required for scanning on Android 10+,
  • removing need for WRITE_EXTERNAL_STORAGE permission. Uri one-time-permissions are now only supported option for file selection,
  • dark theme

@philips77 philips77 requested a review from bgiori March 27, 2020 14:12
@philips77
Copy link
Collaborator Author

Tests fail because of a license for Android API 29. Can you fix it?

@bgiori
Copy link
Contributor

bgiori commented Mar 27, 2020

Tests fail because of a license for Android API 29. Can you fix it?

Can you change line 6 in .circleci/config.yml to

     - image: circleci/android:api-29

@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #70 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #70   +/-   ##
=========================================
  Coverage     13.56%   13.56%           
  Complexity       94       94           
=========================================
  Files            60       60           
  Lines          1873     1873           
  Branches        179      179           
=========================================
  Hits            254      254           
  Misses         1592     1592           
  Partials         27       27

@philips77 philips77 merged commit c866183 into master Mar 30, 2020
@philips77 philips77 deleted the updating-dependencies branch March 30, 2020 20:09
philips77 added a commit that referenced this pull request Apr 3, 2020
@philips77
Updating the sample app (#70)
deeab43 
* All dependencies updated
- Dagger issues fixed
- Remaining views migrated to MaterialComponents

* Target API 29

* Removing need for storage permission

* Unused permission removed

* UI issues fixed (shadows, margins)

* Dark theme

* Docker image updated to Android 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgiori bgiori bgiori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philips77 @bgiori