Remove fishy imports from other extension #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the fishy imports of `_conj` and `trivtuple` from the `TensorOperationsChainRulesCoreExt` within the `TensorKitChainRulesCoreExt`, which is no longer supported in julia 1.11.1
|
The formatcheck is a result of JuliaFormatter v2, I still need to investigate what is changing there |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.12.7 #160 +/- ##
===========================================
- Coverage 82.60% 82.58% -0.02%
===========================================
Files 48 48
Lines 5707 5702 -5
===========================================
- Hits 4714 4709 -5
Misses 993 993 ☔ View full report in Codecov by Sentry. |
|
This should resolve #158 in the 0.12.x versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the fishy imports of
_conjandtrivtuplefrom theTensorOperationsChainRulesCoreExtwithin theTensorKitChainRulesCoreExt, which is no longer supported in julia 1.11.1