Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1 #39

Closed
wants to merge 3 commits into from
Closed

fixes #1 #39

wants to merge 3 commits into from

Conversation

opyate
Copy link

@opyate opyate commented Feb 14, 2019

No description provided.

@opyate
Copy link
Author

opyate commented Feb 14, 2019

node6 is failing because I'm using Object.values.
How does everyone suggest I fix? Shim?

@gpetrioli
Copy link

node6 is failing because I'm using Object.values.
How does everyone suggest I fix? Shim?

I would go with a shim but not sure how @JustinBeckwith feels about adding dependencies.

@opyate
Copy link
Author

opyate commented Feb 14, 2019

@gpetrioli OK, I've just added a values to be called instead of Object.values for now:

// tslint:disable-next-line no-any
const values = (objOrArray: {[key: string]: any}) => {
  return Object.keys(objOrArray).map((key: string) => objOrArray[key]);
};

I'll leave it up to @JustinBeckwith to add a shim/polyfill/etc if he feels OK with extra dependencies.

(...and I've also added the fix for the httpMethodsToRetry ;) )

@JustinBeckwith
Copy link
Owner

Just to make sure I'm not entirely nuts - what version of axios are y'all using where you see this problem?

@gpetrioli
Copy link

This problem is definitely present in 0.18.0 version of axios.

(with axios@next there is a different set of problems)

@JustinBeckwith
Copy link
Owner

Sorry for all the trouble here folks. Super weird bug in axios. This is addressed in #83 in a slightly different way, so closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants