fix: Call onRetryAttempt *after* backoff timeout #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orgads
force-pushed
the
on-retry-after-timeout
branch
2 times, most recently
from
12ce1c8
to
cbb5f41
Compare
|
ping? |
orgads
force-pushed
the
on-retry-after-timeout
branch
3 times, most recently
from
6ca787a
to
f633719
Compare
The log appears before the timeout, which is misleading. Also return support for async onRetryAttempt. Introduce a new onError callback that is called before the timeout. Fixes JustinBeckwith#119.
orgads
force-pushed
the
on-retry-after-timeout
branch
from
f633719
to
04e032e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log appears before the timeout, which is misleading.
Also return support for async onRetryAttempt.
Fixes #119.