Repository navigation
feat(automations): the merge gate sees a pull request's branches and head repository - #688
Merged
Merged
Conversation
Owner
Author
|
Merged by the coordinator. CI was green on the head, with no bot findings. The builder's live proof is in this PR. A scratch merge of current main with #665, #706, #688, #693 and #651 passed: contracts 676 tests, automations 24, the api parity check 21, cloud GitHub and automations 38, mobile 17, plus server layer, compiler and upstream-sync hook tests. Typecheck was clean for contracts, cloud, server, web and mobile. |
This was referenced Oct 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Merge gate can't tell where a pull request comes from:
signalbox.pull_request_readhas no head branch, base branch or head repository. #5's upstream-sync automation needs the signalbox folder's gate to merge its own sync PRs, which touch "hard to undo" paths almost every time, without relaxing anything for a fork's PR. The repo is public, so a fork can run its own workflows and fake check names.Fix
pull_request_readalso returnsheadBranch,baseBranchandheadRepository(another repository's is a fork):headRefName,baseRefNameandheadRepository.nameWithOwnerin the same GraphQL call as before.The default gate doesn't use them. They're on its
PullRequesttype so a customized gate can, and the precompiled built-ins are regenerated.Verification
vp test run src/automations/mergePullRequest.test.ts(cloud): 6 passed, including a new fork case where the gate's "Read the pull request" step showsheadBranch,baseBranch: "main"andheadRepository: "fork/repo".vp test run src/workflows/builtinTools(server): 2 passed, asserting the new fields.packages/automationstests: 24 passed (the precompiled file is current).packages/automations, plus lint on the changed files, are clean.Closes #687. Part of #5, map #384.
🤖 Generated with Claude Code