Repository navigation
fix(shared): answer checkpoint checks during pending truncation - #1026
Merged
Merged
Conversation
This was referenced Oct 18, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A checkpoint check arriving while the worker waits for truncation acknowledgement is dropped. Its caller then keeps a check marked in flight forever; later checkpoints stop and write admission can eventually hang. This remains in the merged #1000 code.
Change
Backport pingdotgg/t3code@7e69ce7d032badca71e8071c0ccbe31101943e12. Answer the check with its request ID, the pending generation and
blocked: true. This releases the in-flight request without accepting an older snapshot as current. Barrier handling stays intact.Scope and approval
Follow-up to #1000 and #779, explicitly requested after the upstream review found the race. The two adapter files match the corrected upstream source. When syncing pingdotgg/t3code#21037, take the upstream version and reconcile this carry.
Verification
vp test run packages/shared/src/nodeSqliteClient.test.ts -t 'answers checks received while the worker waits for truncation acknowledgement' --maxWorkers=1: 1 passed. It queues a check during held truncation, verifies its own reply and the old generation, then proves a later write completes.Independent review found no issues against the exact two-file backport; both file blobs match upstream and the corrected patched-app source.
Independent review: GPT 6.1 Sol xhigh (Opus unavailable: rate-limited at 2026-10-17 15:47:05 UTC).
Implementation: GPT 6.1 Sol through the Codex harness in T3 Code; backported from the upstream fix.