Implement requested changes

JupiterOne-Archives · Jan 24, 2023 · 63bfdf6 · 63bfdf6
1 parent 9177c9e
commit 63bfdf6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/src/steps/account/converter.ts b/src/steps/account/converter.ts
@@ -14,7 +14,6 @@ export function createAccountEntity(
   return createIntegrationEntity({
     entityData: {
       source: {
-        id,
         name,
       },
       assign: {

diff --git a/src/steps/user-group/index.ts b/src/steps/user-group/index.ts
@@ -3,7 +3,6 @@ import {
   Entity,
   IntegrationStep,
   IntegrationStepExecutionContext,
-  Relationship,
   RelationshipClass,
 } from '@jupiterone/integration-sdk-core';
 
@@ -24,21 +23,19 @@ export async function fetchUserGroups({
   const accountEntity = (await jobState.getData(ACCOUNT_ENTITY_KEY)) as Entity;
   const client = createSonarqubeClient(instance.config);
 
-  const convertedUserGroups: Entity[] = [];
-  const relationships: Relationship[] = [];
-  await client.iterateUserGroups((userGroup) => {
-    const userGroupEntity = createUserGroupEntity(userGroup);
-    convertedUserGroups.push(userGroupEntity);
-    relationships.push(
+  await client.iterateUserGroups(async (userGroup) => {
+    const userGroupEntity = await jobState.addEntity(
+      createUserGroupEntity(userGroup),
+    );
+
+    await jobState.addRelationship(
       createDirectRelationship({
         _class: RelationshipClass.HAS,
         from: accountEntity,
         to: userGroupEntity,
       }),
     );
   });
-  await jobState.addEntities(convertedUserGroups);
-  await jobState.addRelationships(relationships);
 }
 
 export const userGroupSteps: IntegrationStep<SonarqubeIntegrationConfig>[] = [