This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Create data model for Web Security Scanner #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-NCSU
commented
Nov 29, 2022
| { | ||
| resourceName: 'Scan Run', | ||
| _type: 'google_cloud_scan_run', | ||
| _class: ['Finding'], |
There was a problem hiding this comment.
Not a great class for this but not sure which one would be better.
There was a problem hiding this comment.
I don't really have a better alternative. If no one else has a complaint, it's probably fine.
JakeFerrero
reviewed
Dec 20, 2022
| }, | ||
| ], | ||
| relationships: [], | ||
| dependsOn: [], |
There was a problem hiding this comment.
Not as familiar with the graph-google-cloud project, but just making sure, there's not service-level entity this would be dependent on?
There was a problem hiding this comment.
Not that I am aware of, I am also not too familiar but from what I could find it didn't need any
JakeFerrero
approved these changes
Dec 21, 2022
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.