This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Initial network ingestion #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
austinkelleher
commented
Oct 3, 2020
•
austinkelleher
commented
austinkelleher
force-pushed
the
initial-networking
branch
from
3401576 to
e63b1c7
Compare
erkangz
suggested changes
Oct 3, 2020
erkangz
suggested changes
Oct 3, 2020
ndowmon
reviewed
Oct 4, 2020
src/steps/compute/converters.ts
Outdated
| * If source service accounts are specified, the firewall rules apply | ||
| * only to traffic originating from an instance with a service account | ||
| * in this list. Source service accounts cannot be used to control | ||
| * traffic to an instance's external IP address because service |
There was a problem hiding this comment.
Suggested change
| * traffic to an instance's external IP address because service | |
| * traffic to an instance's external IP address because service |
Comment on lines
+134
to
+137
| for (const networkInterface of computeInstance.networkInterfaces || []) { | ||
| const subnetwork = networkInterface.subnetwork as string; | ||
|
|
||
| const subnetEntity = await jobState.findEntity(subnetwork); |
There was a problem hiding this comment.
I noticed that this addition added two steps to the dependsOn of fetchComputeInstances- STEP_COMPUTE_NETWORKS and STEP_COMPUTE_SUBNETWORKS.
Can a google_compute_network have a google_compute_instance, or can only a google_compute_subnetwork have a google_compute_instance?
Support for ingesting KSM crypto key rings and crypto keys
erkangz
approved these changes
Oct 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.