Merge pull request #565 from JupiterOne/INT-5629-gh-actions

INT-5629 - Cache packages in `actions/setup-node`
JupiterOne-Archives · Dec 22, 2022 · bbd0a2f · bbd0a2f
2 parents 22c35ca + 384be45
commit bbd0a2f
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 25 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -9,17 +9,18 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
+      - name: Check out code repository source code
+        uses: actions/checkout@v3
+
       - id: setup-node
         name: Setup Node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
           node-version: 14.x
-
-      - name: Check out code repository source code
-        uses: actions/checkout@v2
+          cache: 'yarn'
 
       - name: Install dependencies
-        run: yarn
+        run: yarn --frozen-lockfile
 
       - name: Run tests
         run: yarn test:ci
@@ -36,11 +37,12 @@ jobs:
     name: Checkout Code
     steps:
       - name: Setup Node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
           node-version: 14.x
+          cache: 'yarn'
       - name: Check out repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
           token: ${{ secrets.AUTO_GITHUB_PAT_TOKEN }}

diff --git a/.github/workflows/questions.yml b/.github/workflows/questions.yml
@@ -6,33 +6,36 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - id: setup-node
-        name: Setup Node
-        uses: actions/setup-node@v1
-        with:
-          node-version: 14.x
-
       - name: Check out `main` branch
-        uses: actions/checkout@v2
-        with: 
+        uses: actions/checkout@v3
+        with:
           path: source
-      
+
       - name: Check out target branch questions
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           ref: ${{github.event.pull_request.head.ref}}
           repository: ${{github.event.pull_request.head.repo.full_name}}
           path: target
 
+      - id: setup-node
+        name: Setup Node
+        uses: actions/setup-node@v3
+        with:
+          node-version: 14.x
+          cache: 'yarn'
+
       - name: Install dependencies for `main` branch
-        run: yarn install --cwd source
+        run: yarn install --cwd source --frozen-lockfile
 
       - name: Validate questions on target branch
         env:
-          MANAGED_QUESTIONS_JUPITERONE_ACCOUNT_ID: ${{ secrets.MANAGED_QUESTIONS_JUPITERONE_ACCOUNT_ID }}
-          MANAGED_QUESTIONS_JUPITERONE_API_KEY: ${{ secrets.MANAGED_QUESTIONS_JUPITERONE_API_KEY }}
-        run: yarn --cwd source 
-               j1-integration validate-question-file 
-                 -a $MANAGED_QUESTIONS_JUPITERONE_ACCOUNT_ID 
-                 -k $MANAGED_QUESTIONS_JUPITERONE_API_KEY 
-                 -p ../target/jupiterone/questions/questions.yaml
+          MANAGED_QUESTIONS_JUPITERONE_ACCOUNT_ID:
+            ${{ secrets.MANAGED_QUESTIONS_JUPITERONE_ACCOUNT_ID }}
+          MANAGED_QUESTIONS_JUPITERONE_API_KEY:
+            ${{ secrets.MANAGED_QUESTIONS_JUPITERONE_API_KEY }}
+        run:
+          yarn --cwd source j1-integration validate-question-file -a
+          --frozen-lockfile $MANAGED_QUESTIONS_JUPITERONE_ACCOUNT_ID -k
+          $MANAGED_QUESTIONS_JUPITERONE_API_KEY -p
+          ../target/jupiterone/questions/questions.yaml