forked from sonic-net/sonic-buildimage
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] PSU and module thermals are no longer child of chassis #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
reviewed
Jan 14, 2021
"name": "sfp32", | ||
"thermals": [ | ||
{ | ||
"name": "xSFP module 32 Temp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about other platforms? they should have different numbers of SFP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only for 2700. I don't see this file on other platform.
keboliu
approved these changes
Jan 15, 2021
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Mar 15, 2021
…dules (sonic-net#7046) Included commits in sonic-py-swsssdk repo ``` 4e0c561 2019-11-19 | read portchannel name from LAG_NAME_MAP_TABLE in COUNTERS_DB (#51) [anilkpandey] ``` Included commits in sonic-snmpagent repo ``` 02dc2ce 2021-03-12 | add mock tables for LAG_NAME_MAP_TABLE in COUNTERS_DB (#202) [Qi Luo] ```
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Oct 16, 2023
…ly (sonic-net#16876) #### Why I did it src/sonic-ztp ``` * 739470d - (HEAD -> master, origin/master, origin/HEAD) [ZTP] 'config reload' use -f to avoid system checks (#52) (4 hours ago) [Peter Yu] * 04cd8e8 - [ZTP] bufsize=1 not supported in binary mode (#51) (4 hours ago) [Peter Yu] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jan 8, 2025
…ly (sonic-net#21159) #### Why I did it src/dhcprelay ``` * 2a2fb68 - (HEAD -> master, origin/master, origin/HEAD) Clear counter when dhcp6relay init (#51) (2 hours ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Feb 26, 2025
…ly (sonic-net#21340) #### Why I did it src/dhcprelay ``` * 13d7f5a - (HEAD -> 202411, origin/202411) Add wait and check ip address check when dhcp6relay init (#52) (#66) (25 hours ago) [mssonicbld] * 1e7b13a - [202411] Clear counter when dhcp6relay init (#51) (#65) (4 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Mar 7, 2025
…lly (sonic-net#787) #### Why I did it src/sonic-swss ``` * 3b75e84 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-swss:202411 to 202412 (#51) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
In order to build up device hierachy, PSU and module thermals are no longer child of chassis. PSU thermal belongs to PSU objects and SFP thermals belong to SFP object now. Need align this change in platform.json.
- How I did it
Move thermal objects to correct parent device
- How to verify it
Run platform API test
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)