Make nodes aware of their serial_number.#37
Merged
Julius2342 merged 2 commits intoJulius2342:masterfrom Apr 26, 2020
Merged
Conversation
20 tasks
Fixed tests to support serial_number. Add setter for serial_number in frame for node information.
Owner
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home Assistant wants entities to provide a unique id. Neither the host ip nor the node_id are unique. The PR adds the serial number during node initialization.
If the PR is accepted and pypi version containing the PR is available, I will update home-assistant/core#34668
Regards, Thomas