Revert "Do not call close..." and release 0.9.16#773
Conversation
This reverts commit 03749a4.
ae60b34 to
3621089
Compare
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 77.46% 77.47%
=======================================
Files 38 38
Lines 2561 2562 +1
=======================================
+ Hits 1984 1985 +1
Misses 577 577
Continue to review full report at Codecov.
|
omus
left a comment
There was a problem hiding this comment.
I'm okay with reverting this change as long as we create an issue for removing close as part of a breaking release and mention it in the change logs.
That is one possibility, but let's take the time to discuss it and think it through fully. |
Basically I want to make that issue now |
3621089 to
3e17e94
Compare
|
This is fine by me in terms of keeping the stable releases going. I still think the original patch was the correct approach, so I'll propose it again as a PR, and we can mark it breaking, and decide when to merge it. |
|
See #775 |
Since #752 turned out to be rather breaking I propose a new release with that change reverted. We should also yank 0.9.15 from the registry.
Fixes #772
cc @oxinabox @mattBrzezinski @nickrobinson251 @c42f @quinnj @omus