[Breaking] Remove the type piracy of several Base
functions
#749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the type piracy of several
Base
functions. Specifically, it removes the following pirated methods:Base.startwrite(io::Any)
Base.closewrite(io::Any)
Base.startread(io::Any)
Base.closeread(io::Any)
According to #745 (comment), this is a breaking change. Therefore, I took advantage of the opportunity to bump the version number to
1.0.0
.For context, see: #745 (review) and JuliaLang/julia#42080.