Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the General registry uuid. #333

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Conversation

fredrikekre
Copy link
Member

Otherwise HTTP in a checked out state is considered another package.

@samoconnor
Copy link
Contributor

LGTM. But I don't really grok Pkg3 yet.
@quinnj unless you have a comment on this I'll assume that @fredrikekre is right that this is the correct thing to do.

@fredrikekre
Copy link
Member Author

To give some more context; the METADATA -> General registry converter generates the uuid based on the name, and for now ignores uuid in the repos Project.toml. It should match https://github.com/JuliaRegistries/General/blob/4113ec12bcb4a74ac8ebb212d1069c795d6d48cc/H/HTTP/Package.toml#L2

@quinnj quinnj merged commit a262701 into JuliaWeb:master Oct 16, 2018
@quinnj
Copy link
Member

quinnj commented Oct 16, 2018

Thanks @fredrikekre; yeah, the alternative UUID here came from using Pkg3 very early on while developing HTTP.jl.

@fredrikekre fredrikekre deleted the patch-1 branch October 16, 2018 15:26
samoconnor pushed a commit that referenced this pull request Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants