Skip to content

fix: prevent HEAD requests from writing body in streamhandler #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pankgeorg wants to merge 3 commits into from
Closed

fix: prevent HEAD requests from writing body in streamhandler #1113

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4099389
fix: prevent HEAD requests from writing body
pankgeorg Sep 20, 2023
98b1536
Merge branch 'master' into pg/HEAD-no-body-4
pankgeorg Nov 23, 2023
64d36e2
test: test that HEAD requests don't have return a body
pankgeorg Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Handlers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ function streamhandler(handler)
request.response::Response = handler(request)
request.response.request = request
startwrite(stream)
write(stream, request.response.body)
if request.method != "HEAD"
write(stream, request.response.body)
end
return
end
end
Expand Down