Check if particles are overlapping #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondea
requested changes
Aug 6, 2022
There was a problem hiding this comment.
Hi @Kevish-Napal, massive thanks for your contribution, this looks like a useful check, so thank you for implementing it. Also, great work fighting Pkg and git, I promise you're almost there to your first PR!
One overall comment is that the convention in this package (and most Julia packages) is to use snake_case for variable names and CamelCase for types and modules. Otherwise, this looks like a great first PR.
jondea
requested changes
Aug 8, 2022
jondea
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
It looks good to me, thank you again! I'll let @arturgower have a quick look over and merge it if he's happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, finally found how to interact with Pkg and git correctly!
I wrote the first function isempty(Origins,Radii) where Origins and Radii are vectors so one can easily check this function without having to define particles.
Kevish