Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make close actually save VTK files #149

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Make close actually save VTK files #149

merged 6 commits into from
Sep 18, 2024

Conversation

jipolanco
Copy link
Member

One would expect close to actually write a VTK file to disk (especially since the documentation states so), but this is currently not the case.

This PR fixes this issue by making close equivalent to the old vtk_save function. Moreover, the close function is used instead of vtk_save throughout the code, tests and docs. The vtk_save function still works and is left for backwards compatibility.

Closes #148.

@jipolanco jipolanco force-pushed the close-save branch 2 times, most recently from a8bd2f2 to 99e7c70 Compare September 18, 2024 12:52
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.90%. Comparing base (dc4c34c) to head (d0c26b0).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/WriteVTK.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   96.87%   96.90%   +0.03%     
==========================================
  Files          15       15              
  Lines         863      873      +10     
==========================================
+ Hits          836      846      +10     
  Misses         27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jipolanco jipolanco merged commit f60e984 into master Sep 18, 2024
6 of 7 checks passed
@jipolanco jipolanco deleted the close-save branch September 18, 2024 12:57
@KnutAM
Copy link

KnutAM commented Sep 18, 2024

Amazingly quick response and resolution. Thanks @jipolanco 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document difference between Base.close and vtk_save
2 participants