Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nested calls to apply #90

Merged
merged 9 commits into from
Oct 4, 2021
Merged

Add support for nested calls to apply #90

merged 9 commits into from
Oct 4, 2021

Conversation

tpgillam
Copy link
Contributor

@tpgillam tpgillam commented Oct 1, 2021

Support nested calls to apply, by applying all patches in the current environment, as well as those passed to apply.

src/patch.jl Outdated Show resolved Hide resolved
test/merge.jl Outdated Show resolved Hide resolved
test/nested_apply.jl Outdated Show resolved Hide resolved
test/nested_apply.jl Outdated Show resolved Hide resolved
test/nested_apply.jl Outdated Show resolved Hide resolved
test/nested_apply.jl Outdated Show resolved Hide resolved
test/nested_apply.jl Outdated Show resolved Hide resolved
test/nested_apply.jl Outdated Show resolved Hide resolved
test/nested_apply.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #90 (4fe41c2) into master (a1a98dc) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   83.87%   84.12%   +0.25%     
==========================================
  Files           6        6              
  Lines         124      126       +2     
==========================================
+ Hits          104      106       +2     
  Misses         20       20              
Impacted Files Coverage Δ
src/Mocking.jl 45.45% <ø> (ø)
src/patch.jl 100.00% <100.00%> (ø)
src/expr.jl 100.00% <0.00%> (ø)
src/dispatch.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a98dc...4fe41c2. Read the comment docs.

Copy link

@morris25 morris25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with the package but this seems like a useful change.

src/patch.jl Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
src/patch.jl Outdated Show resolved Hide resolved
src/patch.jl Show resolved Hide resolved
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a pure improvement to me.
Though perhaps should wait for @omus say if there is a problem this causes related to #89
AFAIK they are unrelated.

src/patch.jl Outdated Show resolved Hide resolved
src/patch.jl Outdated Show resolved Hide resolved
src/patch.jl Outdated Show resolved Hide resolved
@omus
Copy link
Member

omus commented Oct 1, 2021

This seems like a pure improvement to me.
Though perhaps should wait for @omus say if there is a problem this causes related to #89
AFAIK they are unrelated.

This doesn't make the problem in #89 any worse so I'm good with that change from that perspective

src/patch.jl Outdated Show resolved Hide resolved
@tpgillam tpgillam merged commit 9fd8321 into master Oct 4, 2021
@tpgillam tpgillam deleted the tg/nested_apply branch October 4, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants