Skip to content

Commit

Permalink
Minor updates around nightly workflow (#127)
Browse files Browse the repository at this point in the history
* Update nightly workflow job name

* Update async world age comments

* Use variable for Aqua stdlibs
  • Loading branch information
omus authored Jul 16, 2024
1 parent 3d17650 commit 6a0c9b9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/JuliaNightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
- cron: "0 2 * * *" # Daily at 2 AM UTC (8 PM CST)
jobs:
test:
name: Julia Nightly - Ubuntu - x64
name: Julia nightly - ubuntu-latest - x64
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 3 additions & 3 deletions test/async-world-ages.jl
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ using Mocking
# can test that patches to functions defined in later world ages can be called
# from mocks in a Task running in an earlier world age.
ch = Channel() do ch
# Block until we've started the patch
# Wait until there is data in the channel
v1 = take!(ch)
# Call the (patched) foo
# Call the (patched) `foo`
v2 = foo(v1)
# return the value
# Return the value into the channel
put!(ch, v2)
end

Expand Down
3 changes: 2 additions & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ Mocking.activate()
@testset "Mocking" begin
@testset "Code quality (Aqua.jl)" begin
# Unable to add compat entries for stdlibs while we support Julia 1.0
Aqua.test_all(Mocking; deps_compat=(; check_extras=(; ignore=[:Dates, :Test])))
stdlibs = [:Dates, :Test]
Aqua.test_all(Mocking; deps_compat=(; check_extras=(; ignore=stdlibs)))
end

include("dispatch.jl")
Expand Down

2 comments on commit 6a0c9b9

@omus
Copy link
Member Author

@omus omus commented on 6a0c9b9 Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/111607

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.7.9 -m "<description of version>" 6a0c9b947709b30017a062a179224b8c9d6df516
git push origin v0.7.9

Please sign in to comment.