Fix ExplicitImports to work with --depwarn=error
#132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into #93 in a (non-public) package where tests are run with
--depwarn=error. It seems that the problematic change was introduced in #17 but as this package does not support Julia < 1.10 anymore, I reverted it.With this PR, downstream tests do not fail anymore (but the deprecation warnings of the deprecated bindings are displayed since it is accessed with
getglobal).Fixes #93.
To some extent, the issue here is similar to JuliaDocs/Documenter.jl#2758. In principle, one could apply the same approach as done in Base in Julia <= 1.11 and check
Base.isbindingresolved(mod, name)before trying to accessgetglobal(mod, name)to avoid triggering the deprecation warning. However, I'm not sure if it's worth it given that Keno removed the need forBase.isbindingresolved(it's deprecated in 1.12 and just unconditionally returnstrue) in JuliaLang/julia#57253, and in the same PR also remove these patternsisbindingresolved(...) && isdefined(...)etc. in base julia.