Skip to content

refactor: improve precompile-friendliness of _iszero and _isone #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AayushSabharwal merged 1 commit into from
Dec 9, 2025
Merged

refactor: improve precompile-friendliness of _iszero and _isone #824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 78 additions & 6 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,45 @@ memoizing results for previously seen values.
@cache function _iszero(x)::Bool
@nospecialize x
x = unwrap_const(unwrap(x))
x isa Number && return iszero(x)::Bool
x isa Array && return iszero(x)::Bool
return false
if x isa Int
return iszero(x)
elseif x isa BigInt
return iszero(x)
elseif x isa Float64
return iszero(x)
elseif x isa Float32
return iszero(x)
elseif x isa BigFloat
return iszero(x)
elseif x isa Rational{Int}
return iszero(x)
elseif x isa Rational{BigInt}
return iszero(x)
elseif x isa Bool
return iszero(x)
elseif x isa ComplexF64
return iszero(x)
elseif x isa ComplexF32
return iszero(x)
elseif x isa Complex{Int}
return iszero(x)
elseif x isa Complex{Rational{Int}}
return iszero(x)
elseif x isa Vector{Int}
return iszero(x)
elseif x isa Vector{Float64}
return iszero(x)
elseif x isa Matrix{Int}
return iszero(x)
elseif x isa Matrix{Float64}
return iszero(x)
elseif x isa Number
return iszero(x)::Bool
elseif x isa Array
return iszero(x)::Bool
else
return false
end
end
"""
$TYPEDSIGNATURES
Expand All @@ -125,9 +161,45 @@ memoizing results for previously seen values.
@cache function _isone(x)::Bool
@nospecialize x
x = unwrap_const(unwrap(x))
x isa Number && return isone(x)::Bool
x isa Array && return isone(x)::Bool
return false
if x isa Int
return isone(x)
elseif x isa BigInt
return isone(x)
elseif x isa Float64
return isone(x)
elseif x isa Float32
return isone(x)
elseif x isa BigFloat
return isone(x)
elseif x isa Rational{Int}
return isone(x)
elseif x isa Rational{BigInt}
return isone(x)
elseif x isa Bool
return isone(x)
elseif x isa ComplexF64
return isone(x)
elseif x isa ComplexF32
return isone(x)
elseif x isa Complex{Int}
return isone(x)
elseif x isa Complex{Rational{Int}}
return isone(x)
elseif x isa Vector{Int}
return isone(x)
elseif x isa Vector{Float64}
return isone(x)
elseif x isa Matrix{Int}
return isone(x)
elseif x isa Matrix{Float64}
return isone(x)
elseif x isa Number
return isone(x)::Bool
elseif x isa Array
return isone(x)::Bool
else
return false
end
end
"""
$TYPEDSIGNATURES
Expand Down
Loading