Skip to content

Fix power rules to fix some of the broken tests in CAS #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0x0f0f0f merged 2 commits into from
Oct 11, 2024
Merged

Fix power rules to fix some of the broken tests in CAS #252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd0ab88
Bugfix in diff(x^n, x) rule and prevent folding 0^0 as well as negati…
gkronber Oct 10, 2024
5e5e912
Merge branch 'ale/3.0' into fix_broken_cas_tests
gkronber Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions test/integration/cas.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ fold_t = @theory a b begin
a::Number + b::Number => a + b
a::Number - b::Number => a - b
a::Number * b::Number => a * b
a::Number^b::Number => begin
a::Number ^ b::Number => begin
a == 0 && b <= 0 && return nothing
a < 0 && b != round(b) && return nothing # only allow integer exponents for negative base
b < 0 && a isa Int && (a = float(a))
a^b
end
Expand All @@ -87,14 +89,14 @@ end
diff_t_base = @theory x y n begin
diff(x, x) --> 1
diff(n::Number, x) --> 0
diff(y^1, x) --> 1
diff(y^(n::Number), x) --> n * y^(n - 1)
# diff(x^1, x) --> 1 # special case of next rule
diff(x^(n::Number), x) --> n * x^(n - 1)
end

diff_t_composite = @theory x a b c begin
diff(a + b, x) == diff(a, x) + diff(b, x)
diff(a * b, x) == diff(a, x) * b + a * diff(b, x) # product rule
# if diff(b,x) == 0
diff(a * b, x) == diff(a, x) * b + a * diff(b, x) # product rule
# if diff(b,x) == 0
# return :( $y * $xp * ($x ^ ($y - 1)) )

diff(a^b, x) == a^b * (diff(b, x) * log(a) + b * (diff(a, x) / a))
Expand Down Expand Up @@ -186,17 +188,14 @@ end
@test :(y + sec(x)^2) == simplify(:(1 + y + tan(x)^2))
@test :(y + csc(x)^2) == simplify(:(1 + y + cot(x)^2))

@test_broken simplify(:(diff(x^2, x))) == :(2x)

@test simplify(:(diff(x^2, x))) == :(2x)
@test_broken simplify(:(diff(x^(cos(x)), x))) == :((cos(x) / x + -(sin(x)) * log(x)) * x^cos(x))
@test simplify(:(x * diff(x^2, x) * x)) == :(2x^3)

@test_broken simplify(:(x * diff(x^2, x) * x)) == :(2x)

# @test_broken simplify(:(diff(y^3, y) * diff(x^2 + 2, x) / y * x)) == :(3y^2)
@test simplify(:(diff(y^3, y) * diff(x^2 + 2, x) / y * x)) == :(6 * y * x ^ 2) # :(3y * 2x^2)

@test simplify(:(6 * x * x * y)) == :(6 * y * x^2)

@test_broken simplify(:(diff(y^3, y) / y)) == :(3y^2)
@test simplify(:(diff(y^3, y) / y)) == :(3y)


# params = SaturationParams(
Expand Down