Skip to content

Change implementation of BackoffScheduler to match egg. #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gkronber wants to merge 16 commits into from
Closed

Change implementation of BackoffScheduler to match egg. #249

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
879d9b4
Inform the scheduler with the corrent number of matches for the rule.…
gkronber Oct 5, 2024
98c7e10
Removed empty line
gkronber Oct 5, 2024
398428b
Check cansearch before @timeit to show the number of calls for the ru…
gkronber Oct 5, 2024
a2ee361
Use threshold from BackoffScheduler as a limit for the ematcher
gkronber Oct 6, 2024
72ff196
Improved handling of limited number of matches.
gkronber Oct 6, 2024
7dd5848
Bugfix: ematcher now returns hash of constants instead of index of en…
gkronber Oct 6, 2024
f540ffd
Fix the MT benchmark code to match code in for egg in egg-benchmarks …
gkronber Oct 7, 2024
6b9907b
Not necessary to search for an enode that is a terminal to store it's…
gkronber Oct 7, 2024
dcfee40
Allow to resize optbuffer
gkronber Oct 8, 2024
d1a3bf0
We do not need to set enode_idx for pattern variables with a predicat…
gkronber Oct 8, 2024
fe02654
Remove unnecessary statement
gkronber Oct 8, 2024
0fecaa5
Change eqsat_search! to call schedulers via search_matches! (in place…
gkronber Oct 8, 2024
3bb3034
Improve debug output and remove trailing whitespace
gkronber Oct 10, 2024
bfe573e
Check size argument for resize(::OptBuffer, n)
gkronber Oct 11, 2024
48578d8
Merge branch 'ale/3.0' into 248_incorrect_nmatches_for_inform
gkronber Oct 16, 2024
4530aae
Merge branch 'ale/3.0' into 248_incorrect_nmatches_for_inform
gkronber Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/EGraphs/saturation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ function eqsat_search!(

@debug "SEARCHING"
for (rule_idx, rule) in enumerate(theory)
prev_matches = n_matches
@timeit report.to string(rule_idx) begin
prev_matches = n_matches
# don't apply banned rules
Expand All @@ -90,24 +89,23 @@ function eqsat_search!(
ids_left = cached_ids(g, rule.left)
for i in ids_left
cansearch(scheduler, rule_idx, i) || continue
n_matches += rule.ematcher_left!(g, rule_idx, i, rule.stack, ematch_buffer)
inform!(scheduler, rule_idx, i, n_matches)
eclass_matches = rule.ematcher_left!(g, rule_idx, i, rule.stack, ematch_buffer)
n_matches += eclass_matches
inform!(scheduler, rule_idx, i, eclass_matches)
end

if is_bidirectional(rule)
ids_right = cached_ids(g, rule.right)
for i in ids_right
cansearch(scheduler, rule_idx, i) || continue
n_matches += rule.ematcher_right!(g, rule_idx, i, rule.stack, ematch_buffer)
inform!(scheduler, rule_idx, i, n_matches)
eclass_matches = rule.ematcher_right!(g, rule_idx, i, rule.stack, ematch_buffer)
n_matches += eclass_matches
inform!(scheduler, rule_idx, i, eclass_matches)
end
end

@gkronber gkronber Oct 5, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For bidirectional rules, the LHS and RHS may both match the same eclass. In this case inform! would be called twice for the same rule index and the same eclass in the same iteration. None of the implemented schedulers uses this, but it could be unexpected for people implementing their own scheduler.


n_matches - prev_matches > 0 && @debug "Rule $rule_idx: $rule produced $(n_matches - prev_matches) matches"
# if n_matches - prev_matches > 2 && rule_idx == 2
# @debug buffer_readable(g, old_len)
# end
inform!(scheduler, rule_idx, n_matches)
inform!(scheduler, rule_idx, n_matches - prev_matches)
end
end

Expand Down