-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utf8proc 1.2 release #30
Comments
Fine by me. Worth doing a sanity check (maybe you have already) that things are still fine when current utf8proc master is linked into Julia? |
I just tried it, and all the Julia tests pass on my machine with the utf8proc master. |
+1 it would be great to fix the unicode character width issues |
Hmm, one final tweak: looking at this, it seems like we need Update: this is now added. |
Is calling runtime |
I'd just like to add support for |
@tkelman, the runtime version is not sufficient if you need to decide at compile-time whether you can call a function like
|
@nalimilan, it is more standard to do |
Yeah, good point.
Distribution buildbots all use |
Thanks, I wasn't familiar with staged installs, so I didn't know about the DESTDIR/prefix dichotomy. (I normally use automake and get all these things for free, but automake seems like overkill here). Looks like we'll also get it for free if we switch to cmake. |
OK, see #31 |
Anything else to check before we are good to go? (I'll fix up the |
Fine with me. |
Looks like you haven't tagged yet, I realized that the Julia build on Windows does use the makefile here. We probably don't want to do the soname symlinking there either. |
Just checked deps/Makefile again - it doesn't use |
Yes, the Julia build only makes the |
Okay, release tag is pushed and website is updated. |
(Unfortunately, I just noticed that there were some stray mojibake references remaining in the |
Now that we have nicer documentation (thanks to #29), as far as I can tell we are ready for a 1.2 release as soon as the version number is updated.
(I don't think it's necessary to wait until we can get the HTML docs into the release tarball; there are equivalent docs in
utf8proc.h
, after all, and in any case the lack of formatted docs in the tarball is not a regression.)@jiahao, @tkelman, @nalimilan, @StefanKarpinski, your thoughts?
The text was updated successfully, but these errors were encountered: