Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Project.toml #23

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Switch to Project.toml #23

merged 1 commit into from
Jan 3, 2020

Conversation

nalimilan
Copy link
Member

No description provided.

@nalimilan nalimilan mentioned this pull request Jan 1, 2020
@nalimilan nalimilan changed the title Add Project.toml Switch to Project.toml Jan 1, 2020
@ararslan
Copy link
Member

ararslan commented Jan 1, 2020

This will also need a version and compatibility entries for each dependency.

@nalimilan
Copy link
Member Author

Given that this is just a meta-package and that we won't tag new versions very frequently, I'd say we'd better not add any bounds. We just want the most recent combination dependencies that are compatible with each other.

@ararslan
Copy link
Member

ararslan commented Jan 1, 2020

I'd agree in general, but I think automatic merging in the General registry requires compatibility bounds for all dependencies.

@KristofferC
Copy link
Member

Things can be non-auto merged though.

@nalimilan
Copy link
Member Author

Yes, as we don't tag releases frequently (only when adding new packages), it's not an issue if we require manual merging.

@ararslan
Copy link
Member

ararslan commented Jan 2, 2020

Okay, sounds good.

@nalimilan nalimilan merged commit 5bfe0aa into master Jan 3, 2020
@nalimilan nalimilan deleted the nl/Project.toml branch January 3, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants