Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pairwise for type-unstable corner case function #772

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Commits on Mar 4, 2022

  1. Fix pairwise for type-unstable corner case function

    `promote_type` is not a completely correct way of computing an upper bound
    for the return eltype. Use the same strategy as `map` and `broadcast` in
    Base instead, but with `promote_eltype` rather than `promote_typejoin`.
    We can still use `typejoin_union_tuple` since promotion does not happen
    inside tuple types.
    
    On Julia versions before 1.6 we would have to copy the full definition of
    `typejoin_union_tuple`, which is quite complex, so instead fall back to
    inferring eltype `Any` (inference wasn't so good anyway on these versions).
    nalimilan committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    0557e93 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Configuration menu
    Copy the full SHA
    626438e View commit details
    Browse the repository at this point in the history
  2. Add tests

    nalimilan committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    650ca27 View commit details
    Browse the repository at this point in the history