Skip to content

Stop using LinearAlgebra.copy_oftype #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Stop using LinearAlgebra.copy_oftype #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/scalarstats.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ function mad(x; center=nothing, normalize::Union{Bool, Nothing}=nothing, constan
# Knowing the eltype allows allocating a single array able to hold both original values
# and differences from the center, instead of two arrays
S = isconcretetype(T) ? promote_type(T, typeof(middle(zero(T)))) : T
x2 = x isa AbstractArray ? LinearAlgebra.copy_oftype(x, S) : collect(S, x)
x2 = x isa AbstractArray ? copyto!(similar(x, S), x) : collect(S, x)
Copy link
Member Author

@nalimilan nalimilan Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this change assumes that when S == T, copyto!(similar(x, S), x) is as fast as copy(x). Not sure whether that holds: I could add another branch to ensure that this simple case is fast.

c = center === nothing ? median!(x2) : center
if isconcretetype(T)
x2 .= abs.(x2 .- c)
Expand Down