Make countmap support iterators

[Moelf]

fix #581

[nalimilan]

Thanks!

[Moelf]

@nalimilan isn't the non-copy method defined on 345L for AbstractArray? what's the problem of using collect here

[nalimilan]

@nalimilan isn't the non-copy method defined on 345L for AbstractArray? what's the problem of using collect here

sort makes a copy, that's why I proposed using sort!.

[Moelf]

@nalimilan done. Last thing, what needs to be changed for addcounts!(cm::Dict{Bool}, x::AbstractArray{Bool}; alg = :ignored) etc. ?

[nalimilan]

Yes that's would be nice too, as it gives higher performance for these cases.

[Moelf]

sorry, I just don't know what "change" were you referring to. They look like different specialized function to handle different T again.

[nalimilan]

I mean that they should accept any x of the right eltype, not just AbstractArray. That requires a few dispatch tricks by passing eltype(x) and an argument and dispatching on that.

[Moelf]

maybe we should just collect once at the very beginning at let the rest do their own thing....

because there's no parametric types for iterator and I don't like jamming eltypes everywhere in the function body to manual dispatch

actually, I have an idea let me try.

[Moelf]

@nalimilan how about this?

[Moelf]

done. Manually adding special case for x that doesn't have length is quite annoying, maybe a re-factor is called....

[nalimilan]

Thanks @Moelf!