Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Fill return type in mvlognormal tests #1890

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Aug 26, 2024

In JuliaArrays/FillArrays.jl#385 I'm working on improving how broadcasting works for FillArrays. One of the changes is that some types may be inferred differently, so e.g.
Currently

julia> exp.(Zeros(2))
2-element Fill{Float64}, with entries equal to 1.0

Proposed:

julia> exp.(Zeros(2))
2-element Ones{Float64}

Currently, in one of the mvlognormal tests, this package is explicitly checking for a Fill. This PR relaxes this to a Union{Fill, Ones} so that the tests pass either way.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.99%. Comparing base (00b7fad) to head (fdae203).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1890   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files         144      144           
  Lines        8666     8666           
=======================================
  Hits         7452     7452           
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devmotion devmotion merged commit e1340f0 into JuliaStats:master Aug 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants