Skip to content

Conversation

@trappmartin
Copy link

No description provided.

@devmotion
Copy link
Member

Thanks for the PR! I wonder why

params(d::DiscreteNonParametric) = (d.support, d.p)
is not sufficient? In any case, could you add some tests that are broken currently and fixed by the PR?

@trappmartin
Copy link
Author

Good question, no idea.

@trappmartin
Copy link
Author

In any case, could you add some tests that are broken currently and fixed by the PR?
Sure, can give it a try.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Base: 85.84% // Head: 85.84% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3bb19fa) compared to base (7b3890d).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 3bb19fa differs from pull request most recent head a87b5d9. Consider uploading reports for the commit a87b5d9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1606   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files         129      129           
  Lines        8016     8018    +2     
=======================================
+ Hits         6881     6883    +2     
  Misses       1135     1135           
Impacted Files Coverage Δ
src/univariate/discrete/discretenonparametric.jl 98.27% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@trappmartin
Copy link
Author

I added a test to the categorical distribution as I encountered the issue when using it.

Nice, TBH, I didn't check. Thanks!

Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@devmotion devmotion merged commit b7916c6 into JuliaStats:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants