This repository has been archived by the owner on May 4, 2019. It is now read-only.
Fixed xtab and added docstrings #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @cgoldammer, sorry for the delay in getting back to you. This has since been implemented so I'm going to close this PR. Thanks for the contribution, it's nonetheless appreciated! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with
xtabmentioned in #145 by usingsort(collect(keys))instead ofsort(keys). Also, I added docstrings and did minor refactoring.I'd be happy to help with docstrings for the rest of the package, but from what I understand now is not the best time for this, because you're working on major changes to the internals of the
DataArray.