Use @inline instead of @generate when possible

JuliaStats · Feb 12, 2017 · a2bb139 · a2bb139
1 parent 4dbce68
commit a2bb139
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/src/indexing.jl b/src/indexing.jl
@@ -161,21 +161,17 @@ function Base.getindex(pda::PooledDataArray, I::Real)
     end
 end
 
-@generated function Base.getindex(pda::PooledDataArray, I::Integer...)
-    quote
-        if getindex(pda.refs, I...) == 0
-            return NA
-        else
-            return pda.pool[getindex(pda.refs, I...)]
-        end
+@inline function Base.getindex(pda::PooledDataArray, I::Integer...)
+    if getindex(pda.refs, I...) == 0
+        return NA
+    else
+        return pda.pool[getindex(pda.refs, I...)]
     end
 end
 
 # Vector case
-@generated function Base.getindex(A::PooledDataArray, I::Union{AbstractVector,Colon}...)
-    quote
-        PooledDataArray(RefArray(getindex(A.refs, I...)), copy(A.pool))
-    end
+@inline function Base.getindex(A::PooledDataArray, I::Union{AbstractVector,Colon}...)
+    PooledDataArray(RefArray(getindex(A.refs, I...)), copy(A.pool))
 end
 
 ## setindex!: DataArray